fix: correct PUT /api/v1/provider silently dropping model_type, endpoint_url, encrypted_config (#1627)#1673
Open
carlosjarenom wants to merge 2 commits into
Conversation
…ver READMEs (eigent-ai#1579) The READMEs recommended Python 3.10, but pyproject.toml and Dockerfile require Python 3.12. This caused confusion for users trying to set up the server locally. Closes eigent-ai#1579
…int_url, encrypted_config (eigent-ai#1627) The _UPDATABLE_FIELDS whitelist used obsolete field names (api_base, extra_config) that no longer exist in the ModelProvider model. When updating a provider via PUT, the actual fields model_type, endpoint_url and encrypted_config were silently ignored. Updated the whitelist to use the correct field names matching the ModelProvider model definition. Closes eigent-ai#1627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ProviderService.update()uses a field whitelist that doesn't match the actualProviderORM model fields:api_baseendpoint_url)extra_configencrypted_config)model_typeendpoint_urlencrypted_configPUT
/api/v1/provider/{id}returns 200 OK but silently drops updates tomodel_type,endpoint_url, andencrypted_config.Fix
Replace the incorrect whitelist entries with the actual
Providerfield names:api_base→endpoint_urlextra_config→encrypted_configmodel_type(was missing)Note:
is_vaildtypo is project-wide and kept as-is (out of scope).Reproduction
claude-opus-4-6model_typetogpt-4o, click Save → success toastCloses #1627