Repository navigation
Support reduced motion - #2918
Merged
Merged
Conversation
leolost2605
force-pushed
the
leolost/reduced-motion
branch
from
September 2, 2026 10:03
5306da9 to
d02d4b5
Compare
leolost2605
force-pushed
the
leolost/reduced-motion
branch
2 times, most recently
from
September 10, 2026 16:49
a47c401 to
cf120f2
Compare
leolost2605
force-pushed
the
leolost/reduced-motion
branch
2 times, most recently
from
October 9, 2026 16:53
887fcb7 to
347fbac
Compare
leolost2605
force-pushed
the
leolost/reduced-motion
branch
from
October 11, 2026 17:39
347fbac to
9699183
Compare
lenemter
approved these changes
Oct 11, 2026
lenemter
left a comment
lenemter
left a comment
Member
There was a problem hiding this comment.
LGTM. This doesn't take into account Utils.get_animation_duration but it's fine for now as it's unclear what behavior is expected
Reduced motion will be needed across the whole code base rather often. Going through the style manager is a long line of code so add a simple getter.
leolost2605
force-pushed
the
leolost/reduced-motion
branch
from
October 11, 2026 20:36
9699183 to
663093c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2917
Not sure whether we should replace disabling animations or just use reduce motion additionally. I went with the second because completely disabling animations is still useful as a performance option.
This PR now doesn't animate when reduced motion is on. However in addition I added reduce motion handling to the transition builder to allow to have pure opacity transitions still running.
This means that now window open/delete/minimize etc. only do the opacity transition and not the scale.
As for the rest there are a few places where we already use opacity but don't use transition builder. I think we should port those to transition builder and then support reduce motion properly (in a follow up).
However I think for other places that don't already do opacity, like switching workspaces or opening the multitasking view it doesn't make a lot of sense to add an extra crossfade transition for now. This would probably need a lot of refactoring and doesn't bring the advantage that the normal animation brings (i.e. conveying information about switching left, right, etc.)