Repository navigation
Implement a touch screen backend - #2949
Open
leolost2605 wants to merge 8 commits into
Open
leolost2605 wants to merge 8 commits into
leolost2605 wants to merge 8 commits into
Conversation
leolost2605
force-pushed
the
leolost/new-touchscreen-backend
branch
2 times, most recently
from
October 9, 2026 15:21
3a2b12a to
d5fe8e0
Compare
This was referenced Oct 9, 2026
leolost2605
force-pushed
the
leolost/new-touchscreen-backend
branch
from
October 11, 2026 17:38
c83ba07 to
5b61cc1
Compare
lenemter
requested changes
Oct 11, 2026
| } | ||
|
|
||
| public double get_distance (GestureAction action) { | ||
| return 500; |
Member
There was a problem hiding this comment.
Where did this value come from?
Member
Author
There was a problem hiding this comment.
Nowhere :) It's currently not used because zoom uses pinch and that's not implemented yet and even when we implement it we probably don't use it because with pinch we want to send a percentage (based on current distance between fingers and initial distance between fingers).
I kind of forgot I added that here 😅 I changed get_distance to be a virtual method and added documentation that get_distance only applies to swipe gestures
leolost2605
force-pushed
the
leolost/new-touchscreen-backend
branch
2 times, most recently
from
October 11, 2026 21:29
3396967 to
e925d3f
Compare
This makes sure that a gesture detected by a backend isn't accidentally accepted by a different trigger than the one that added the gesture.
leolost2605
force-pushed
the
leolost/new-touchscreen-backend
branch
from
October 13, 2026 22:21
e925d3f to
513f518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OS 9 doesn't package touchegg so we have to implement it ourselves. This also allows some improvements (most notably one to one finger tracking of touch screen gestures: #1272 )
See the individual commits for an easier review:
Fixes #1272
Fixes #1801
The new
TouchScreenSwipeBackendis only available when compiled against mutter 49 or higher (because there the new pangesture was introduced), older versions have to rely on touchegg.Changes in behavior compared to touchegg are:
In this PR it's currently not yet used for the edge swipe gesture but I already have a working follow up for that (#2950)