Repository navigation
Indicator: create header settings if it doesn't exist - #360
Merged
danirabbit merged 3 commits intoOct 6, 2026
Merged
Conversation
flodavid
reviewed
Sep 12, 2026
| // Create value if it doesn't exist and set true | ||
| var settings = new Settings ("io.elementary.panel.notifications"); | ||
| var headers = (HashTable<string, bool>) settings.get_value ("headers"); | ||
| if (!headers.contains (notification.desktop_id)) { |
There was a problem hiding this comment.
headers can be null here I think, so we should check for nullability ?
Member
There was a problem hiding this comment.
Probably it doesn't unless we give a key that doesn't exist?
ryonakano
reviewed
Oct 4, 2026
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
ryonakano
approved these changes
Oct 6, 2026
danirabbit
deleted the
danirabbit/indicator-notificationcreateheadersetting
branch
October 6, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we get a new notification, make sure that we create visibility settings before trying to bind to it in items and headers