Repository navigation
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8762-codexno-sizing-pass View snapshot changes at kitdiff |
yay
force-pushed
the
codex/no-sizing-pass
branch
from
October 22, 2026 13:36
1778e84 to
81b9edc
Compare
yay
force-pushed
the
codex/no-sizing-pass
branch
from
October 22, 2026 14:03
81b9edc to
c433904
Compare
yay
marked this pull request as ready for review
October 22, 2026 14:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
UiBuilder::no_sizing_pass()so a child can use normal layout inside a sizing parent while retaining its actual ancestry and inherited UI properties. This is useful for clipped contents whose size does not determine their container’s allocation.Default inheritance remains unchanged. The override does not cancel pass discarding or change visibility, enabled state, or input handling.
Compatibility: the public
UiBuilder::sizing_passfield changes frombooltoOption<bool>(Noneinherits). Existing callers that assign the field directly need to useSome(...)or the builder methods.Example: simplifying a fixed-viewport content UI
The override replaces a separate root and reconstructed ancestor chain with a normal child:
The actual parent chain also keeps
ui.close()andui.close_kind()working without copying container metadata.Tests cover inheritance and override precedence, widget layout, live ancestry and closing, inherited properties, and unchanged discard/input behavior.
Closes #8760.