Repository navigation
ci: set up MSVC environment for Windows native-image build - #13
Merged
Merged
Conversation
The Windows native-build job fails at nativeCompile because native-image can't auto-detect Visual Studio on the runner (setup-graalvm skips MSVC env setup for GraalVM JDK 17+). Export the MSVC env explicitly via ilammy/msvc-dev-cmd before the first gradlew call, mirroring the fix in engine-public/protoc-gen-openapi#38. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
native-build.yamlfailed during release run 37479267549 atnativeCompile: "Please make sure that Visual Studio 2022 version 17.1.0 or later is installed on your system."setup-graalvmskips MSVC env setup for GraalVM JDK 17+ and relies on native-image auto-detecting Visual Studio, which fails on this runner.ilammy/msvc-dev-cmdstep (SHA-pinned, v1.13.0) before Gradle starts so the daemon and native-image child inherit the MSVC env. Same fix as ci: set up MSVC environment for Windows native-image build protoc-gen-openapi#38.Test plan
release.yamlafter merge and confirm thewindows-x86_64native build succeeds.🤖 Generated with Claude Code