Fix exponential notation#3
Open
strange-dv wants to merge 1 commit intoericseppanen:masterfrom
Open
Conversation
Owner
|
Thanks for the patch! This repository is meant to match the code in my blog post, so I don't want to make any changes that would cause the two to diverge. I may come back and update the blog post in the future, so I'll leave this PR open to remind me to fix it then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a small fix for parsing exponential notation, which allows to use of the capital letter
Efor this purpose.The existing test for parsing floating point numbers has also been extended to catch this case.