Update to Elixir 1.20#466
Conversation
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: code patterns and functional logic verified for system integrity.
|
Interesting. I can see a lot of warnings now, but all of them stem from this code, right? As long as the tests pass, I'm fine with ignoring the warnings for now. We can address them when we actually need to work on the logic of the project again, or wait for improvements in the type checker. |
|
That’s right, it’s all from that piece of code. From what I can see, the logic is sound, it’s just that some modules provably can’t use all branches, but all branches are used by some module so we can’t remove any. Thanks for reviewing and merging all of these :) |
Before merging, exercism/elixir#1635 needs to be merged and pulled here
We get a bunch of compiler warnings because of all the macro shenanigans that this repo is the master of. I tried fixing them, but I gave up pretty quickly. I suspect that these warnings will be fixable once type annotations are a thing though, not all hope is lost.