Skip to content

fix: SQL injection in WorkFlowDAO by using parameterized Criteria API - EXO-87040 #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akhanfir merged 2 commits into from
Jun 9, 2026
+51 −25
Merged

fix: SQL injection in WorkFlowDAO by using parameterized Criteria API - EXO-87040 #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72addf6
fix: SQL injection in WorkFlowDAO by using parameterized Criteria API…
akhanfir Jun 5, 2026
19cf0e2
fix: SQL injection in WorkFlowDAO by using parameterized Criteria API…
akhanfir Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 51 additions & 25 deletions processes-services/src/main/java/org/exoplatform/processes/dao/WorkFlowDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,49 +51,75 @@ public List<WorkFlowEntity> findAllWorkFlows(int offset, int limit) {
return resultList == null ? Collections.emptyList() : resultList;
}

private String buildWorkflowQuery(ProcessesFilter processesFilter, List<String> memberships) {
private String buildWorkflowQuery(ProcessesFilter processesFilter, List<String> memberships) {

String q = processesFilter.getQuery();
Boolean enabled = processesFilter.getEnabled();
Boolean manager = processesFilter.getManager();
boolean isProcessManager = processesFilter.getIsProcessManager();
String query = " ( workFlow.title like '%" + q + "%' OR workFlow.description like '%" + q + "%' OR workFlow.summary like '%" + q + "%' )";
String queryString = "SELECT DISTINCT workFlow FROM WorkFlow workFlow";

StringBuilder queryString =
new StringBuilder("SELECT DISTINCT workFlow FROM WorkFlow workFlow");

if (enabled != null || Boolean.TRUE.equals(manager) || !isProcessManager) {

if (memberships != null) {
if ( Boolean.FALSE.equals(manager)) {
queryString = queryString + " LEFT JOIN workFlow.manager manager";
if (Boolean.FALSE.equals(manager)) {
queryString.append(" LEFT JOIN workFlow.manager manager");
}
queryString = queryString + " LEFT JOIN workFlow.participator participator";
queryString.append(" LEFT JOIN workFlow.participator participator");
}
if (StringUtils.isNotEmpty(q) || memberships != null || enabled != null){
queryString = queryString + " WHERE";
if (StringUtils.isNotEmpty(q)){
queryString = queryString + query;
queryString = queryString + " AND";
if (StringUtils.isNotEmpty(q) || memberships != null || enabled != null) {
List<String> predicates = new ArrayList<>();
if (StringUtils.isNotEmpty(q)) {
predicates.add("""
(workFlow.title LIKE :query
OR workFlow.description LIKE :query
OR workFlow.summary LIKE :query)
""");
}
if ( enabled != null){
queryString = queryString + " workFlow.enabled = " + enabled;
queryString = queryString + " AND";
if (enabled != null) {
predicates.add("workFlow.enabled = :enabled");
}
if ( memberships != null){
if ( Boolean.FALSE.equals(manager)){
queryString = queryString + " ( manager IN ('"+String.join("','", getMembersShipGroup(memberships))+"') ";
queryString = queryString + " OR participator IN ('"+String.join("','", memberships)+"')) ";
if (memberships != null) {
if (Boolean.FALSE.equals(manager)) {
predicates.add("(manager IN :managers OR participator IN :memberships)");
} else {
queryString = queryString + " participator IN ('"+String.join("','", memberships)+"') ";
predicates.add("participator IN :memberships");
}
}
if (queryString.endsWith(" AND")) {
queryString = queryString.substring(0, queryString.length() - 4);
if (!predicates.isEmpty()) {
queryString.append(" WHERE ")
.append(StringUtils.join(predicates, " AND "));
}
}
} else {
if (StringUtils.isNotEmpty(q)) {
queryString = queryString + " WHERE" + query;
queryString.append(" WHERE (workFlow.title LIKE :query")
.append(" OR workFlow.description LIKE :query")
.append(" OR workFlow.summary LIKE :query)");
}
}

return queryString;
return queryString.toString();
}

private Query createQuery(String queryString, ProcessesFilter processesFilter, List<String> memberships) {
Query query = getEntityManager().createQuery(queryString);

if (StringUtils.isNotEmpty(processesFilter.getQuery())) {
query.setParameter("query", "%" + processesFilter.getQuery() + "%");
}

if (processesFilter.getEnabled() != null) {
query.setParameter("enabled", processesFilter.getEnabled());
}

if (memberships != null) {
query.setParameter("memberships", memberships);
query.setParameter("managers", getMembersShipGroup(memberships));
}
return query;
}

private List<String> getMembersShipGroup(List<String> memberships) {
Expand Down Expand Up @@ -144,7 +170,7 @@ public int countWorkFlows(ProcessesFilter processesFilter) {
public List<WorkFlowEntity> findWorkFlows(ProcessesFilter processesFilter, List<String> memberships, int offset, int limit) {

String queryString = buildWorkflowQuery(processesFilter, memberships);
Query query = getEntityManager().createQuery(queryString);
Query query = createQuery(queryString, processesFilter, memberships);
query.setFirstResult(offset);
if (limit > 0) {
query.setMaxResults(limit);
Expand All @@ -155,7 +181,7 @@ public List<WorkFlowEntity> findWorkFlows(ProcessesFilter processesFilter, List<

public int countWorkFlows(ProcessesFilter processesFilter, List<String> memberships) {
String queryString = buildWorkflowQuery(processesFilter, memberships);
Query query = getEntityManager().createQuery(queryString, Long.class);
Query query = createQuery(queryString, processesFilter, memberships);
return query.getMaxResults();
}

Expand Down