Repository navigation
Conversation
sqlparse tokenizes CREATE OR REPLACE as a single keyword, so the CREATE entry never matched and such statements passed the blacklist. Fixes explorerhq#704.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparse tokenizes
CREATE OR REPLACE ...as a single keyword token, so the existingCREATEblacklist entry never matches and these statements passpasses_blacklist.Fixes #704
Changes:
explorer/app_settings.py: add"CREATE OR REPLACE"to defaultEXPLORER_SQL_BLACKLISTdocs/settings.rst: mirror the default in docsexplorer/tests/test_utils.py: regression testtest_ddl_create_or_replaceTesting:
manage.py test explorer.tests.test_utils-- 43 tests OK; new test fails without the fix and passes with it.