Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/recover-warm-recording-manifest-20261029 #4780 +/- ##
================================================================================
Coverage ? 76.52%
================================================================================
Files ? 1100
Lines ? 55074
Branches ? 12125
================================================================================
Hits ? 42138
Misses ? 11949
Partials ? 987 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a64b604 to
e96c015
Compare
18a84ff to
d8aedc6
Compare
d8aedc6 to
c45fed5
Compare
c45fed5 to
d9f42a1
Compare
|
Codex rebased this PR onto main Current head: Earlier contribution and validationCodex moved this draft above #4789, after #4735. This PR's removal patch is byte-for-byte unchanged. All 59 focused recording and agent-device tests, build-tools typecheck, scoped lint and formatting pass on the rebased stack. Keep this draft until Universe passes install_app_path and legacy queued, retry and rollback jobs have drained. Szymon's earlier approval is preserved; the updated base still needs human review. — Codex |
d6de7df to
4ed9319
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4ed9319 to
2e22f4c
Compare
…device sessions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Edited-by: Codex
2e22f4c to
edc37a8
Compare
|
✅ Thank you for adding a changeset! |
Why
Once www supplies the downloaded app path, the agent-device step no longer needs to download apps itself.
How
Remove
build_id,application_archive_urland the built-in download fromeas/start_agent_device_session. Workflows download witheas/download_buildand pass itsartifact_pathasinstall_app_path.Based on #4789, after #4735.
Keep this PR draft and outside the current release. Merge and deploy only after www passes
install_app_pathand old queued, retry and rollback jobs have drained. The changeset is major for@expo/build-tools.How app delivery is split
eas/download_build: downloads the app and exposes itsartifact_path. Universe setsextensionsto[app]for iOS and[apk]for Android.install_app_path, then installs and launches the app. It no longer selects or downloads a build itself.#4723 keeps the old inputs working until this migration is live. This separate layer removes them afterward, including the warm step's cold compatibility path. Keep it draft and outside the current release until www passes
install_app_path.Test Plan
2e22f4c, including Node 22 and Node 24; Codecov confirms all modified and coverable lines are covered. The earlier Devin archive-selection question is resolved below.Authorship and LLM use
Gabe asked to separate the breaking removal from #4723. Claude Code wrote the removal, which Szymon approved. Codex moved the unchanged patch above #4789; the updated base still needs human review.
Rollback
Revert this PR to restore
build_idandapplication_archive_url.— Codex