Skip to content

[build-tools] Remove build_id and application_archive_url from agent-device sessions - #4780

Draft
gwdp wants to merge 1 commit into
gwdp/recover-warm-recording-manifest-20261029from
gwdp/agent-device-install-app-path-only
Draft

gwdp wants to merge 1 commit into
gwdp/recover-warm-recording-manifest-20261029from
gwdp/agent-device-install-app-path-only

Conversation

@gwdp

@gwdp gwdp commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Why

Once www supplies the downloaded app path, the agent-device step no longer needs to download apps itself.

How

Remove build_id, application_archive_url and the built-in download from eas/start_agent_device_session. Workflows download with eas/download_build and pass its artifact_path as install_app_path.

Based on #4789, after #4735.

Keep this PR draft and outside the current release. Merge and deploy only after www passes install_app_path and old queued, retry and rollback jobs have drained. The changeset is major for @expo/build-tools.

How app delivery is split
  • www/job config: supplies a workflow that downloads the app before starting the session.
  • eas/download_build: downloads the app and exposes its artifact_path. Universe sets extensions to [app] for iOS and [apk] for Android.
  • Agent-device session step: accepts that path as install_app_path, then installs and launches the app. It no longer selects or downloads a build itself.

#4723 keeps the old inputs working until this migration is live. This separate layer removes them afterward, including the warm step's cold compatibility path. Keep it draft and outside the current release until www passes install_app_path.

Test Plan

  • 59 focused recording and agent-device tests, build-tools typecheck, scoped lint and formatting pass on the rebased stack. This PR's patch is byte-for-byte unchanged. CI passes on head 2e22f4c, including Node 22 and Node 24; Codecov confirms all modified and coverable lines are covered. The earlier Devin archive-selection question is resolved below.
  • This layer only receives the updated base; its removal is unchanged. Keep it draft until the www migration and legacy jobs have drained.

Authorship and LLM use

Gabe asked to separate the breaking removal from #4723. Claude Code wrote the removal, which Szymon approved. Codex moved the unchanged patch above #4789; the updated base still needs human review.

Rollback

Revert this PR to restore build_id and application_archive_url.

— Codex

@gwdp
gwdp added this pull request to stack #4767 October 29, 2026 00:09
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (gwdp/recover-warm-recording-manifest-20261029@2f4dc99). Learn more about missing BASE report.

Additional details and impacted files
@@                               Coverage Diff                                @@
##             gwdp/recover-warm-recording-manifest-20261029    #4780   +/-   ##
================================================================================
  Coverage                                                 ?   76.52%           
================================================================================
  Files                                                    ?     1100           
  Lines                                                    ?    55074           
  Branches                                                 ?    12125           
================================================================================
  Hits                                                     ?    42138           
  Misses                                                   ?    11949           
  Partials                                                 ?      987           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gwdp added a commit that referenced this pull request Oct 29, 2026
…device sessions

Squashed from a64b604 (PR #4780).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch from a64b604 to e96c015 Compare October 29, 2026 03:05
@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch 2 times, most recently from 18a84ff to d8aedc6 Compare October 29, 2026 06:22
@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch from d8aedc6 to c45fed5 Compare October 29, 2026 06:45
@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch from c45fed5 to d9f42a1 Compare October 29, 2026 19:06
@gwdp

gwdp commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex rebased this PR onto main 6f0f90bd9 and restacked its dependencies. The removal remains draft until the www migration and legacy-job drain.

Current head: edc37a8b0ec2eb63d52d4527d35140aca1bae3fb. Stack-level local checks: 496 focused build-tools tests and 59 worker tests passed on the rebased main stack; 154 artifact-drain/host tests passed on #4750. Build-tools, worker and launcher typechecks, scoped lint and formatting pass. CI passes on this exact head, including Node 22 and Node 24; prior human reviews apply to the earlier heads. Draft states and human review requests are preserved.

Earlier contribution and validation

Codex moved this draft above #4789, after #4735. This PR's removal patch is byte-for-byte unchanged. All 59 focused recording and agent-device tests, build-tools typecheck, scoped lint and formatting pass on the rebased stack. Keep this draft until Universe passes install_app_path and legacy queued, retry and rollback jobs have drained. Szymon's earlier approval is preserved; the updated base still needs human review.

— Codex

@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch 2 times, most recently from d6de7df to 4ed9319 Compare October 29, 2026 22:44
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch from 4ed9319 to 2e22f4c Compare October 30, 2026 06:51
@gwdp
gwdp removed this pull request from stack #4767 October 30, 2026 06:55
@gwdp
gwdp changed the base branch from gwdp/prepared-appium-session-20261024 to gwdp/recover-warm-recording-manifest-20261029 October 30, 2026 06:55
@gwdp
gwdp added this pull request to stack #4792 October 30, 2026 06:55
…device sessions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Edited-by: Codex
@gwdp
gwdp force-pushed the gwdp/agent-device-install-app-path-only branch from 2e22f4c to edc37a8 Compare October 30, 2026 17:01
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants