Repository navigation
Conversation
|
✅ Thank you for adding a changeset! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4795 +/- ##
==========================================
+ Coverage 76.38% 76.42% +0.04%
==========================================
Files 1093 1095 +2
Lines 54720 54815 +95
Branches 12026 12043 +17
==========================================
+ Hits 41794 41887 +93
- Misses 11939 11941 +2
Partials 987 987 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Android simulator sessions already write emulator stdout/stderr and native logcat on the worker, but those files are unavailable after the session. When an emulator disappears during a transition or video playback, the existing session logs cannot explain why.
How
Summary
The new Linux-only step has no required inputs. It collects only registered workflow directories, retains at most the last 20 MiB per file, and labels truncated artifacts visibly and in metadata. Files retain their unique launch-prefixed names and use kind
simulator-log.Each upload gets an independent 30-second budget and two attempts. Growing files have a fixed byte-range snapshot; retries reuse those bytes. Collection, upload, and snapshot cleanup failures are nonfatal. Concurrent or repeated collection does not duplicate successful artifacts. This includes a patch changeset for
@expo/build-tools.The companion Universe PR #32975 appends the step with
if: '${{ always() }}'for Android device sessions. Deploy a worker containing this step before enabling that workflow change. Collection requires cleanup to run while the worker survives; this does not add crash classification, kernel logs, or periodic upload.Test Plan
Evidence
Codex ran the following locally; all passed:
yarn workspace @expo/build-tools jest-unit --runInBand \ androidEmulatorLogs.test.ts androidEmulatorLogsUpload.test.ts \ collectAndroidEmulatorLogs.test.ts startAndroidEmulator.test.ts \ startAgentDeviceSession.test.ts AndroidEmulatorUtils.test.ts \ uploadWithSignedUrl.test.ts # 7 suites, 94 tests passed yarn workspace @expo/build-tools typecheckType-aware Oxlint passed on all 11 changed TypeScript files with zero warnings/errors. Oxfmt checked all 12 changed files, the formatter ran again before commit, and
git diff --checkpassed.GitHub CI passed on Node 22 and Node 24.
Staging validation
Codex executed six live cases on 2026-10-30 using the internal
expo/eas-sim-create-teststaging project and Android API 35:adb emu killand cleanup. This does not simulate host SIGKILL/OOM.ERRORED. This tests failure after emulator boot; actual boot failure is covered by unit tests.All test sessions are terminal. The original staging Android worker was restored and its original checksum verified; the temporary PR API/website deployments were removed. Production and customer sessions were unchanged. The tests used the PR runtime code; a separate temporary branch only changed the artifact-building workflow. Worker archive build, preview deployment and E2E checks.
Merge Danger
Door: two-way
The new collector can be disabled in the generated workflow. Roll out the worker step before its universe caller.
Blast Radius: Android
Android device-session cleanup adds bounded log uploads through existing artifact permissions. Worker loss can still prevent collection. The draft remains open for human review.
Authorship and LLM use
The human scoped the work to existing emulator/logcat artifacts and authorized staging-only validation. Codex authored the implementation and tests and ran the local checks above. Parent-agent and separate read-only agent review identified cleanup deduplication, visible truncation, and retry handling issues; those were addressed, and final agent review found no remaining actionable issues. Human inspection and approval of the final diff are pending. Codex executed the staging checks above; human inspection and approval remain pending. This PR must remain a draft.