Skip to content

Test IDA 9.0 to 9.5 in CI and tighten the release workflows - #64

Open
r0ny123 wants to merge 11 commits into
familiary:mainfrom
r0ny123:ci-release-hardening
Open

r0ny123 wants to merge 11 commits into
familiary:mainfrom
r0ny123:ci-release-hardening

Conversation

@r0ny123

@r0ny123 r0ny123 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

The IDA integration job only ran on 9.3. It now runs on every version we say we support, 9.0 to 9.5, and it got faster on the way: hcli ida install does the download, licence and EULA in one go, so a job takes about a minute and a half instead of three.

Running 9.0 turned up a real bug: ida_undo.create_undo_point(name, label) only exists from 9.1, so on 9.0 importing labels (and anything else that changes the database) died with a TypeError. Fixed in IdaBackend, with a changelog entry.

The rest:

  • Releases build every asset first, attach them to a draft, then publish. Nothing is public with a file missing, and it fits immutable releases.
  • A release needs pytest, Validate and (for IDA) all six IDA jobs green on the exact commit.
  • New binja-tests.yml for the licensed Binary Ninja run. It skips itself until BN_LICENSE_B64 and BN_DOWNLOAD_URL_LINUX_X64_STABLE are set, so it is not part of the release gate yet.
  • The Ghidra download is checked against its SHA-256, and workflows are checked with actionlint.
  • Dropped steps that only repeated what Validate and pytest already do.

All six IDA versions and Ghidra pass on my fork, and so do the Windows and macOS jobs (IDA 9.5, headless only), which now run on pushes to main and manual runs instead of behind a tick box. The release workflows themselves have not run yet, a release is the only thing that triggers those.

Note

This touches ghidra-tests.yml, RELEASING.md and docs/development.md, same as #61. Happy to rebase onto whichever goes in first.

…is built

CI
- IDA integration runs the live headless and GUI suite on Linux for every
  minor version from 9.0 to 9.5 instead of 9.3 alone. The dispatch-only
  matrix keeps the offline IDALib check on Windows and macOS, now on 9.5.
  install_idalib_runtime.py installs the bundled bindings whether IDA ships
  them as a wheel or, as 9.0 and 9.1 do, as a source package.
- The matrix jobs no longer repeat the metadata, settings, ruff and plugin
  lint checks that the Validate and IDA package workflows run, and install
  their Python packages with uv.
- A Binary Ninja integration workflow runs the same suite through Binary
  Ninja headless and in the GUI. It needs the BN_LICENSE_B64 and
  BN_DOWNLOAD_URL_LINUX_X64_STABLE secrets and is skipped without them.
- Ghidra integration verifies the SHA-256 of the Ghidra download, cancels
  superseded runs and uploads its logs next to the screenshots.
- Validate runs actionlint. Workflows that run on push ignore tag pushes,
  so pushing a release tag starts no second CI run. Jobs have timeouts.
- Integration artifacts no longer include the IDA user directories, which
  hold the licence registry.

Releases
- The IDA and Binary Ninja release workflows build the offline dependency
  bundles before anything is published, attach them and the plugin archive
  to a draft release, and then publish it. A failed bundle build used to
  leave a published release without its bundles, and assets cannot be added
  to an immutable release after publication.
- verify_release_ci.py replaces the inline check of the pytest workflow. It
  reads the newest push or dispatch run on the release commit, so an older
  green run cannot hide a newer failure, and for IDA requires all six
  integration jobs to have succeeded rather than been skipped. Binary Ninja
  releases are gated on pytest and Validate only until its CI secrets exist.
- The release jobs run the unit tests on the verified commit and refuse to
  publish if the tag moved after verification.
idapro from IDA 9.0 and 9.1 failed to load libidalib.so when the run used an
isolated IDAUSR, so the headless integration never started on those versions.
… point

On IDA 9.0 the bundled PyQt5 is importable under IDALib, and ida-settings
imports QtCore from it when it is loaded. The check is about what the plugin's
entry point imports, so load ida-settings before taking the baseline.
ida_undo.create_undo_point takes an action name and a label from IDA 9.1 on.
IDA 9.0 exposes only the form that takes a packed record, so the call raised
TypeError and importing labels, like every other mutation, stopped there. The
change now goes ahead on 9.0 without an undo point.
Skipping the undo point let the change through but left an import of labels
as separate undo steps. IDA 9.0 accepts the record the SDK's two-string helper
packs: both strings, each zero-terminated.
Whether a second release can be created for a tag that only has a draft
is not something the release notes should assert; the advice to delete
the failed draft first holds either way. The pytest workflow can also be
dispatched by hand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant