Repository navigation
ci: keep openapi.json and the adapter manifest versioned with the package - #440
Merged
Merged
Conversation
…kage Regenerate both in the Changesets version step and fail the contract test when either drifts from the routes or from package.json. Closes #395
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395. Part of the v0.19 release (#385).
Why
openapi.jsonandadapter-manifest.jsonsaid 0.17.0 through the whole 0.18.0 release. Changesets bumpspackage.jsonin the version step but never regenerated either file, and the contract test skippedinfofor exactly that reason. Nothing compared the committed manifest at all.What
version-packagesnow runschangeset version && npm run generate:api, so every release PR carries regenerated files at the new versioninfoexclusion), checksinfo.versionagainstpackage.json, and compares the committedadapter-manifest.jsonwith the live manifest, includingapiVersionOnce this merges, the Changesets action reruns the version script and the open release PR (#425) picks up both files at 0.19.0.
Checks
npm run typecheck: passnpm run lint: passnpm run format:check: passnpm run coverage: 136 files, 1812 passed, 1 todo. Statements 98.9%, branches 95.37%, functions 99.26%, lines 99.14%apiVersion0.17.0 vs 0.18.0), so they catch the driftNot a contract change: no routes, schemas or tokens change, only the version fields.