Skip to content

docs: refactor added frontend_url and app_name - #34

Merged
Bccorb merged 3 commits into
mainfrom
issue_24
Oct 7, 2026
Merged

Bccorb merged 3 commits into
mainfrom
issue_24

Conversation

@PetN5026

Copy link
Copy Markdown
Contributor

Summary

Added mentions of frontend_url and app_name in appropriate files.
What this change does and why.

Related Issue

Closes #24

Changes

Checklist

  • Follows the repo's AGENTS.md and the org REPO-STANDARDS
  • Conventional Commit messages; descriptive branch name
  • All applicable checks pass: tests, lint, type check, formatting
  • No AI or assistant attribution anywhere in commits, PR text, or docs
  • No em dashes in public-facing text
  • Docs updated if behavior or public contracts changed

@PetN5026
PetN5026 requested a review from Bccorb July 24, 2026 19:12

@Bccorb Bccorb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run the application with these changes you should see this breaks the tables. Also need descriptions of the frontend url purpose.

| `RPID` | WebAuthn relying party ID |
| `ORIGINS` | Comma-separated WebAuthn browser origins |
| `APP_NAME` | Application name shown in auth experiences |
| `FRONTEND_URL` | |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the description?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched the source of truth section, but I still didn't get the use.

| `rpid` | `RPID` | string | WebAuthn relying party ID |
| `origins` | `ORIGINS` | URL array | WebAuthn allowed browser origins |

| `frontend_url` | `FRONTEND_URL` | URL | |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the description?

| `RPID` | String |
| `APP_NAME` | String |

| `frontend_url` | String |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final pipe that closed the table properly.

Comment thread src/content/docs/start/firstAdmin.mdx Outdated
Comment on lines +11 to +14
<Aside type="note">
This is a self-hosted path.
</Aside>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Bccorb added 2 commits October 6, 2026 21:11
Fill in the empty FRONTEND_URL and frontend_url purpose cells from the
auth API source (base for sign-in and magic-link URLs, falling back to
the first origin), restore the blank lines that ended each table, use
the env name in the env parsing table, and drop the unrelated note added
to the first admin page.
@Bccorb
Bccorb self-requested a review October 7, 2026 01:59
@Bccorb
Bccorb merged commit b678c01 into main Oct 7, 2026
3 checks passed
@Bccorb
Bccorb deleted the issue_24 branch October 15, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: document frontend_url / FRONTEND_URL system config key

2 participants