Repository navigation
docs: read the service secret from SEAMLESS_SERVICE_TOKEN in examples - #217
Merged
Merged
Conversation
The adapter READMEs now read the app-side service secret from SEAMLESS_SERVICE_TOKEN. The auth server keeps reading API_SERVICE_TOKEN; both hold the same value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app-side service token env var is now
SEAMLESS_SERVICE_TOKEN. The auth API server still readsAPI_SERVICE_TOKEN; both hold the same value.serviceSecretfromSEAMLESS_SERVICE_TOKEN(wasSERVICE_SECRET), with one sentence in each explaining the two names.The adapter reads no environment variables itself; these are app-side example and fixture names only.
Left as
API_SERVICE_TOKENon purpose: the express README's external-delivery paragraph, thedeliverAuthMessagewarning text, and the CHANGELOG, which all refer to the auth server's own setting.Checks
pnpm buildandpnpm testpass.