Repository navigation
feat(enrollment): add schemas for tracking and inviting passkey enrollment - #87
Merged
Merged
Conversation
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fells-code/seamless-auth-api#338 (epic fells-code/seamless-auth-api#334).
After an import, the remaining work is getting everyone onto a passkey, ideally two authenticators each. These are the schemas for seeing who has enrolled and for inviting the rest.
Changes
EnrollmentStatusSchema(none,one,two_or_more), counted in WebAuthn credentials. TOTP does not count.AdminEnrollmentQuerySchema: pagination, plusorganizationId,status,importedandsearch.AdminEnrollmentResponseSchema: a per-statussummarythat ignores the status filter, the filteredusers, andtotal. This also feeds the coverage report in #178.EnrollmentInviteRequestSchematakes exactly one ofuserIds(up to 200) ororganizationId, plusstatus(noneorone, defaultnone) and an optionalsignInUrlvalidated like other redirect targets.EnrollmentInviteResponseSchemareportssent,skipped,remaining(organization-wide calls only) and a result per user, with a skip reason and an externaldelivery.AuthDeliverySchema: newenrollment_invite_emailkind (to,signInUrl), for external delivery mode.AUTH_EVENT_TYPES:admin_enrollment_invite_sent.SystemConfigSchema.prompt_passkey_enrollment(defaultfalse), also patchable. With it set, email or phone code sign-ins (OTPVerifyTokenSuccessSchema) and magic link sign-ins (MagicLinkPollSuccessSchema) carrynextStep: 'enroll_passkey'for a user with no passkey. That is what sends an invited user into enrollment after they sign in.NextStepSchemais now shared withOAuthLoginSuccessResponseSchema.Downstream
kind. seamless-auth-server'sdeliverAuthMessagehas no exhaustive check and pins types ^0.4.0 (server#169).Checks
npm run typecheck,npm run lint,npm run format:check,npm test(276, 11 new) andnpm run buildpass.