Repository navigation
feat(verify): run the browser specs against a SvelteKit app - #260
Merged
Merged
Conversation
Adds svelte and svelte-dev layers that drive an app on @seamless-auth/svelte through the same specs as the React template, from a SvelteKit 3 reference app in verify/svelte-app (a single-page app on adapter-static) until a Svelte web template exists. It joins the REFERENCE_APPS list with SEAMLESS_SVELTE_DIR as its override, and --local packs the client and Svelte packages into verify/svelte-vendor. The app serves /health itself, since the SvelteKit dev server has no fallback page for the harness to wait on. Refs fells-code/seamless-auth-react#172.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the browser conformance specs against a SvelteKit app, for the browser project item of fells-code/seamless-auth-react#172 (under fells-code/seamless-auth-api#371).
What changes
svelteandsvelte-devPlaywright projects point at the existing./reactspecs, asangularandvuedo.verify/svelte-app. It runs SvelteKit 3 withadapter-staticas a single-page app (the top of the binding's SvelteKit range), built from its own Dockerfile:runtimetarget serves the app with nginx, with/healthand a runtimeconfig.js.devtarget runsvite dev./healthitself through a prerendered endpoint, because SvelteKit's dev server has no fallback page for the harness to wait on.REFERENCE_APPS, overridable withSEAMLESS_SVELTE_DIR. A web template whoseverify.projectorframeworkissvelteuses the new runtime.--localpacks@seamless-auth/clientand@seamless-auth/svelteintoverify/svelte-vendor.Checks (real output)
node dist/index.js verify --local --devwas run against this branch, seamless-auth-api, seamless-auth-server and seamless-templates at origin/main, and seamless-auth-react at fells-code/seamless-auth-react#181. All 13 layers passed:Merge order
This is a draft until fells-code/seamless-auth-react#181 is merged and
@seamless-auth/svelteis published: