Repository navigation
fix(init): pin seamless-templates v0.19.1 - #268
Merged
Merged
Conversation
v0.19.1 moves the Express, Fastify and Next.js starters onto core 0.20.0, which fixes the cookie guard accepting the pre-auth cookie as a session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix. seamless-cli 0.23.0 (and 0.22.0) scaffold starters whose Express, Fastify and Next.js adapters resolve
@seamless-auth/core0.19.1. That core's cookie guard accepted any adapter-signed cookie, so the pre-auth cookie/loginissues for an existing account from an email address alone passedrequireAuthas that account. Fixed in fells-code/seamless-auth-server#211 (core 0.20.0); the starters move to it in fells-code/seamless-templates#118, released as templates v0.19.1.This bumps
SEAMLESS_TEMPLATES_REFtov0.19.1andSEAMLESS_TEMPLATES_COMMITto89ebd0f, with a patch changeset.Verification
npm run check:templates-pin: matches v0.19.1npm test: 1274 passed, 4 skippedinit --local --yes --email=... </dev/nullwith--express,--fastify,--nextjs: each exits 0 and the scaffolded package.json has@seamless-auth/express ^0.20.0,@seamless-auth/fastify ^0.11.1,@seamless-auth/nextjs ^0.4.0; the Next.js auth route exportsPUTRelease this promptly after merge.