Repository navigation
docs(readme): describe the owner grant as the auth server applies it - #290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said both signup paths prove control of the address before the account is created. For email OTP that is not so:
POST /registration/registercreates the account, with the owner's role, before the code is verified. What keeps it safe is that an unverified account cannot sign in. It now says that, and that the role isadmin:write(oradmin), assrc/lib/ownerAdmin.tsin seamless-auth-api grants it.The API docs get the same correction in fells-code/seamless-auth-api#458, and the docs site in fells-code/seamless-auth-docs#119. README only; the pre-commit hook's tests and build passed.