Repository navigation
More RRULE extending - #14
Merged
Merged
Conversation
This simplifies the expansion by a ton, because it allows concepts like not creating each day of a month only to then select Sundays (for example). It also simplifies some branches in the code (like: what to do if the occurences array is empty? is it empty because all dates have been filtered or is it empty because no filter has been set?) Additionally, each expander is in charge of keeping dates sorted, meaning that those who don't require extra sorting just don't have to apply it while those that might create dates out of sorting can apply it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more RRULE functionality. Added support for:
Also, support has been completed for:
It also refactors the internal rrule engine, keeping a scoped context instead of a list of dates - which makes it way more efficient, because now only the actual requested dates are generated (at where index-based access isn't required).
Also, fixes some bugs.