Skip to content

[Repo] fix: Container hostnames as env vars and pinned lint actions - #73

Merged
finallyjay merged 2 commits into
mainfrom
fix/hostname-vars
Nov 6, 2026
Merged

finallyjay merged 2 commits into
mainfrom
fix/hostname-vars

Conversation

@finallyjay

Copy link
Copy Markdown
Owner

Summary

  • pihole and plex: the container hostname was hard-coded. It now comes from the required variables PIHOLE_HOSTNAME and PLEX_HOSTNAME, documented in each README and .env.example. Plex uses the hostname as its default server name, so set it to the current value to keep clients unchanged.
  • lint-markdown.yml: actions/checkout and markdownlint-cli2-action are pinned by commit SHA (v7.0.1, v25.0.0), the same convention as validate-compose.yml.

Deployment notes

  • The variables are already set in the deployment with the previous value, so merging only redeploys both stacks with the same hostname (a few seconds of downtime).

🤖 Generated with Claude Code

finallyjay and others added 2 commits November 6, 2026 03:01
The hostname was hard-coded in the public repo. It now comes from
PIHOLE_HOSTNAME / PLEX_HOSTNAME (required), documented in each README
and .env.example.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same convention as validate-compose.yml; Dependabot keeps them updated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 36b11766-fb5c-42cd-b0bf-84495d6f9cbf
Commits

Reviewing files that changed from the base of the PR and between 7854be6 and bf5f1b2.

Files selected for processing: 7

  • .github/workflows/lint-markdown.yml
  • pihole/.env.example
  • pihole/README.md
  • pihole/docker-compose.yml
  • plex/.env.example
  • plex/README.md
  • plex/docker-compose.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@finallyjay
finallyjay merged commit ba7d127 into main Nov 6, 2026
6 checks passed
@finallyjay
finallyjay deleted the fix/hostname-vars branch November 6, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant