feat: add discovery-based Firebolt connections#522
Draft
kop wants to merge 6 commits into
Draft
Conversation
Co-authored-by: Ivan Koptiev <kop@users.noreply.github.com>
Co-authored-by: Ivan Koptiev <kop@users.noreply.github.com>
Co-authored-by: Ivan Koptiev <kop@users.noreply.github.com>
Co-authored-by: Ivan Koptiev <kop@users.noreply.github.com>
Co-authored-by: Ivan Koptiev <kop@users.noreply.github.com>
Co-authored-by: Ivan Koptiev <kop@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
host=discovery connection path for sync and async DB-API connections.get.firebolt.io, start the local container, and run the core integration suite against it.Testing
pytest tests/unit/db/test_connection.py::test_connect_discovery tests/unit/db/test_connection.py::test_connect_discovery_rejects_legacy_parameters tests/unit/db/test_connection.py::test_connect_discovery_validation tests/unit/async_db/test_connection.py::test_connect_discoverypytest tests/unit/db/test_connection.pypytest tests/unit/async_db/test_connection.pypython -m compileall -q src/firebolt/common/discovery.py src/firebolt/db/connection.py src/firebolt/async_db/connection.py tests/unit/discovery_connection_helpers.pymypy src/firebolt/common/discovery.py src/firebolt/db/connection.py src/firebolt/async_db/connection.pypyflakes src/firebolt/common/discovery.py src/firebolt/db/connection.py src/firebolt/async_db/connection.py tests/unit/discovery_connection_helpers.py tests/unit/db/test_connection.py tests/unit/async_db/test_connection.pypre-commit run black --files ...pre-commit run isort --files ...Note: running both sync and async connection test files in one pytest invocation exposes a pre-existing cross-file cache interaction in
test_connect_system_engine_caching; each file passes when run independently. Fullpre-commit run --all-filesis blocked locally on Python 3.12 by hook environment issues, but the CI Python 3.9 log showed only a fixedE501line-length failure. Local Docker is unavailable here, so the new end-to-end Firebolt discovery integration test is intended to run in CI.Linear Issue: FB-1831