Repository navigation
feat(world-id): verify with World ID for a keyless bucket of your own - #330
Open
erikengervall wants to merge 2 commits into
Open
erikengervall wants to merge 2 commits into
erikengervall wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 9 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds a hidden firecrawl world-id flow that stores a World ID credential locally and sends it on keyless requests; this new auth/data-handling mechanism needs human sign-off on the credential-storage and identity-header tradeoff.
View guided diff | Turn on auto-fix | Re-trigger cubic
erikengervall
force-pushed
the
capy/verify-with-world-id
branch
7 times, most recently
from
October 20, 2026 19:16
77f747d to
862a322
Compare
erikengervall
force-pushed
the
capy/verify-with-world-id
branch
from
October 20, 2026 19:59
862a322 to
fe09c92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
firecrawl world-id(hidden for now) so keyless users can verify with World ID and get a keyless bucket keyed on their World ID instead of their IP. This is the client side of firecrawl/firecrawl#4934.firecrawl world-id verifyruns the API's device flow:POST /v2/keyless/world-id/device, prints the link and code (and opens the link unless--no-browser), then pollsPOST /v2/keyless/world-id/tokenwith thedevice_handle. It follows the RFC 8628 poll errors (authorization_pending,slow_down,access_denied,expired_token) and stores the returnedfcwid_credential inworld-id.jsonnext tocredentials.json(mode 0600).firecrawl world-id statusandfirecrawl world-id clear.keylessRequest,keylessGet, keyless parse and interact) sendsx-firecrawl-world-idwhile the credential is unexpired.FIRECRAWL_WORLD_IDoverrides the stored credential. Requests with an API key never send it.The command is registered hidden, like
sql, because the API side is off by default. Unhide it once World ID is enabled on the API.Tests
src/__tests__/commands/world-id.test.ts: device flow to a stored credential, 404 when off,slow_downbackoff and a declined approval, a World ID outside the allowlist, code expiry, the header on keyless POST and GET only while unexpired, env override, file mode.pnpm test(699 passed),pnpm run type-check,pnpm run format:check.Summary by cubic
Adds
firecrawl world-idso keyless users can verify with World ID and get a keyless bucket keyed on their World ID instead of their IP. The command stays hidden until the API side is enabled; version bumps to 1.27.0.Details
firecrawl world-id verifyruns the API device flow, shows the link and code, and opens the browser without a shell unless--no-browser;statusandclearround out the command.fcwid_credential asx-firecrawl-world-iduntil it expires;FIRECRAWL_WORLD_IDoverrides the stored credential, and API-key requests never send it.slow_downbackoff, refuses credentials without a valid expiry, and the browser opener rejects non-web URLs.Written for commit fe09c92. Summary will update on new commits.