Repository navigation
feat(setup): configure Amp, Grok Build and Zed with setup mcp - #340
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds Amp, Grok Build, and Zed as config-file targets for firecrawl setup mcp, with new jsonc/toml dependencies and tests. The core file-writing and key-handling implementation is truncated, so the behavior could not be verified end-to-end.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review |
@capy-ai[bot] I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 32 files
Shadow auto-approve: would auto-approve with 1 open P3 issue. Adds setup mcp targets for Amp, Grok Build, and Zed via user-settings config writing, plus an env-configurable integration tag; the feature is well-tested, key-safe, and bounded to CLI tooling.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review |
@capy-ai[bot] I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 32 files
Shadow auto-approve: would auto-approve with 1 open P3 issue. Adds Amp, Grok Build, and Zed as firecrawl setup mcp targets via key-safe user-config writes, plus an opt-in FIRECRAWL_INTEGRATION tag; well-tested and bounded to CLI tooling, with only a README/docs change since the prior approval.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds Amp/Grok/Zed config-file MCP targets plus an integration-tag feature, init step reorder, and SDK/dependency bumps. The core config-writing and key-handling implementation in setup.ts is truncated and unverifiable, so the security-relevant behavior needs human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
be477ff to
f97b63d
Compare
|
@cubic-dev-ai review |
@capy-ai[bot] I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review |
@capy-ai[bot] I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review |
@capy-ai[bot] I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 11 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds Amp, Grok Build, and Zed as setup mcp config-file targets plus prompt/init non-interactive refactors; the new user-config writes and a dismissed comment-only-settings edge case are unresolved behavior decisions.
View guided diff | Turn on auto-fix | Re-trigger cubic
2eabf9d to
7f47606
Compare
1 participant
Adds Amp, Grok Build and Zed as
firecrawl setup mcptargets, so users of those clients no longer hand-edit config to follow the docs quickstarts. Bumps the version to 1.26.17, on top of the 1.26.16 in #339.What it writes
Each client gets the hosted entry (
https://mcp.firecrawl.dev/v2/mcp) in its user settings, following that client's documented format:--agentvaluesamp,ampcode,amp-code~/.config/amp/settings.json(orsettings.jsoncwhen only that exists)"amp.mcpServers".firecrawl = { url, headers? }grok,grok-build,grok-cli~/.grok/config.toml[mcp_servers.firecrawl]withurland optionalheaderszed~/.config/zed/settings.json($XDG_CONFIG_HOME/zedon Linux,%APPDATA%\Zedon Windows)context_servers.firecrawl = { url }Sources:
amp.mcpServers,url/headers,${VAR_NAME}expansion) and https://ampcode.com/docs/cli/settings (settings file locations)[mcp_servers.<name>]in~/.grok/config.toml;${VAR}expands inurl,command,args,envandheaders)context_serverswithurl/headers) and https://zed.dev/faq (~/.config/zed/settings.json)Key handling
The rules match the existing targets. A stored key is never written. With
FIRECRAWL_API_KEYexported, Amp and Grok Build getAuthorization: Bearer ${FIRECRAWL_API_KEY}, which both clients expand when they load the file. Zed does not expand environment variables in MCP headers (zed-industries/zed#60459). So Zed takes the keyless entry only: with an exported key,--agent zedfails with the same "no verified environment-variable syntax" error unknown clients get, and--agent allskips it, as it already does for Antigravity.--keylessincludes it.Editing existing files
jsonc-parser'smodify, so comments, trailing commas, formatting and other servers are kept. A file that does not parse is left alone and reported.config.toml, the existing[mcp_servers.firecrawl]table and its subtables are replaced in place, and every other line, comments included, is kept. The result is checked withsmol-tomlbefore anything is written. Invalid TOML, or a firecrawl entry defined inline where setup cannot replace it, is reported and the file is not changed.add-mcp.add-mcp@1.14.0has no Amp or Grok Build target, and it writes Zed to~/Library/Application Support/Zed/settings.jsonon macOS, while Zed reads~/.config/zed/settings.json.--agent amp|grok|zed --projectis rejected, and--agent all --project(keyless) skips them with a reason.New runtime dependencies:
jsonc-parserandsmol-toml, both with no dependencies of their own.Testing
setup.test.ts, each with a tempHOME, for every client. They cover the env-backed and keyless entries, keeping existing settings and comments, idempotent reruns,settings.jsoncfallback, replacing an old Grok firecrawl table, refusing invalid or unreplaceable TOML,XDG_CONFIG_HOMEfor Zed, rejecting stored keys and--project, and--agent allwith and without an exported key.setup mcp --agent ampand--agent grokwith an exported key wrote env references only (no literal key anywhere under the home).--agent zedwith a key exited 1.--agent zed --keylessadded the entry and kept the existing comments.amp mcp listshowsfirecrawl url https://mcp.firecrawl.dev/v2/mcpfrom~/.config/amp/settings.json, andgrok mcp list --json(Grok 1.0.62, run with a placeholder key) shows the firecrawl server with the header expanded from the environment.pnpm test,pnpm type-check,pnpm format:check,pnpm build.Merge order
Merge after #339. 336 and 338 are merged. This branch has 339 merged in to settle the overlapping lines in
package.jsonand thesetup.tsimports, so until 339 merges its diff also shows its changes. It ships in 1.26.17.Summary by cubic
Adds Amp, Grok Build, and Zed as
firecrawl setup mcptargets so users no longer hand-edit config to follow the docs quickstarts. Bumps thefirecrawlSDK to 4.50.0 and the CLI to 1.26.17.Each client gets the hosted MCP entry in its user settings:
~/.config/amp/settings.json(or an existingsettings.jsoncwhen there's nosettings.jsonfor Amp),~/.grok/config.toml, and~/.config/zed/settings.json($XDG_CONFIG_HOME/zedon Linux when set,%APPDATA%\Zedon Windows). A stored key is never written: Amp and Grok Build get aBearer ${FIRECRAWL_API_KEY}header their clients expand at load time, while Zed is skipped when a key is exported since it cannot expand env vars in headers. All three are user-settings-only, so--projectis rejected. Existing files keep comments and unrelated servers viajsonc-parserandsmol-toml; Grok'sconfig.tomlis preserved byte for byte outside the replaced[mcp_servers.firecrawl]table. Aliasesampcode,amp-code,grok,grok-build, andgrok-climap to the same targets.Written for commit 7f47606. Summary will update on new commits.
Found by Wildfire, Firecrawl's integration testing: the
cli-setup-mcpcheck warned that Amp, Grok Build and Zed were documented but never configured.