Skip to content

fix(search): remove task context from MCP search inputs - #531

Merged
KrisOei merged 2 commits into
mainfrom
kris/remove-mcp-search-objective
Oct 13, 2026
Merged

KrisOei merged 2 commits into
mainfrom
kris/remove-mcp-search-objective

Conversation

@KrisOei

@KrisOei KrisOei commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Remove objective and clientModel from all advertised MCP Search schemas and outbound search requests. Discard legacy values before strict search-surface validation so cached clients continue to work. Feedback objectives, non-search model metadata, and extension hooks are unchanged.

Validation: build, lint, typecheck, and targeted search, contract, feedback-hint, and extension-hook checks passed locally. MCP transport checks use a stubbed API backend; live hosted-backend validation remains pending.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Removes objective from the advertised MCP firecrawl_search schema and outbound /v2/search bodies while tolerating legacy input. This is a public contract change and live backend end-to-end validation is still pending, so human sign-off is needed.

View guided diff | Turn on auto-fix | Re-trigger cubic

@capy-ai capy-ai Bot changed the title fix(search): remove objective from MCP search inputs fix(search): remove task context from MCP search inputs Oct 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 13 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Removes objective and clientModel from the public MCP search schema and outbound /v2/search requests, while discarding legacy inputs for compatibility. This is a public contract and backend-behavior change, and live hosted-backend validation remains pending.

View guided diff | Turn on auto-fix | Re-trigger cubic

@KrisOei
KrisOei merged commit 06ffeb3 into main Oct 13, 2026
2 checks passed
@rakshith48 rakshith48 mentioned this pull request Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant