Repository navigation
Send title, description, website and icons in the initialize result - #541
JuampiHernandez wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Auto-approved with 1 open P3 issue: Adds Firecrawl title, description, website and icons to the MCP initialize serverInfo via a fastmcp patch and a new description hook, with tests, README, and contract snapshots. Change is additive, backward-compatible, and pinned by tests.
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
3e58d9f to
6445fcb
Compare
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds Firecrawl title, description, website, and icons to the MCP initialize serverInfo via a fastmcp patch, with a configurable description hook and contract snapshots/tests pinning the new fields. Bounded additive metadata only; tools, auth, and other behavior are unchanged.
View guided diff | Turn on auto-fix | Re-trigger cubic
| builtInTool(name: string): ToolDefinition | undefined; | ||
| }; | ||
|
|
||
| const DEFAULT_SERVER_DESCRIPTION = |
There was a problem hiding this comment.
We need to mention about Alexandria here
There was a problem hiding this comment.
Added. The default description now ends with "...extract structured data and run Alexandria, the catalogue of structured data providers", and the search-only surface mentions Alexandria too.
6445fcb to
c4d07e2
Compare
There was a problem hiding this comment.
All reported issues were addressed across 10 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Dismissed because Cubic found issues in a newer review.
fastmcp builds the initialize result with only name and version, so the bundled patch now also accepts title, description, websiteUrl and icons server options (title, websiteUrl and icons use the upstream option names). The server sets them next to the unchanged name, and a new description hook lets a surface replace the default text; the search-only surface uses it so it does not advertise tools it does not have.
c4d07e2 to
a4072a0
Compare
There was a problem hiding this comment.
0 issues found across 10 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds optional title, description, website, and icons to the MCP initialize serverInfo via a fastmcp patch, with a configurable description hook and contract snapshots/tests pinning the new fields. Bounded additive metadata only; tools, auth, and other behavior are unchanged.
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch has not been deployed
2 participants
This is one of three small PRs split out of #540 (server info,
idempotentHint, input descriptions), plus a release PR that merges last.MCP clients and directories read the server's title, description, website and icon from the
initializeresult. Ours sends onlynameandversion, because fastmcp builds that result from those two fields alone.Changes
patches/fastmcp@4.3.2.patch: the existing patch now also acceptstitle,description,websiteUrlandiconsserver options and sends them ininitialize.title,websiteUrlandiconsuse upstream fastmcp's option names, so those hunks drop out when we upgrade.descriptionis not upstream.pnpm-lock.yamlonly gets the new patch hash.src/server.ts: sets the four fields next toname(stillfirecrawl-fastmcp, origin attribution keys on it) and adds an unstabledescriptionhook, with the default text, so an embedder can replace it.src/service/index.ts: the search-only surface sets its own description, because the default one mentions crawl, map and parse, which that surface does not have (Cubic's comment on Add server info, idempotent hints and input descriptions #540).README.md:descriptionrow in the hooks table.tests/server-info.test.mjsand regenerated contract snapshots.How I tested it
pnpm install --frozen-lockfile,pnpm run build,pnpm test: 169/169 (168 on main plus the new test).CLOUD_SERVICE=true: connects and reads the new fields without schema errors. Tool lists and results are unchanged apart from the server info.Heads up
Independent of the other PRs. It does not bump the version; the release PR does.