Repository navigation
feat(search): always include Alexandria in authenticated firecrawl_search - #549
Conversation
…arch Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
All reported issues were addressed across 21 files
Requires human review: Authenticated searches now always append Alexandria to caller-supplied sources, overriding explicit web-only requests, with fallback retry and copy changes. This alters the public sources contract, so a human should decide on the product/behavior tradeoff.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 10 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Authenticated firecrawl_search now always appends Alexandria to caller-provided sources, changing the public tool contract and domainTools defaults; dismissed P3 copy issue about zdr/anon exceptions remains.
View guided diff | Turn on auto-fix | Re-trigger cubic
Authenticated
firecrawl_searchnow always asks for Alexandria provider matches, including when the caller passes sources that leave it out.Behaviour
sources(authenticated)sourcesomitted or[]["web", "alexandria"](unchanged)["web"](unchanged)["web"]["web", "alexandria"]["web"]["news"],["web", "images"]"alexandria"[{ type: "web" }][{ type: "web" }, { type: "alexandria" }](form preserved, since the API rejects mixed arrays)["alexandria"]alonealexandriais never duplicated;exchangestill normalizes toalexandria.enterprise: ["zdr"]or["anon"]does not get Alexandria added, because the API refuses provider discovery for those modes.domainToolskeeps defaulting to true when Alexandria is combined with web, news or images; an explicitdomainTools: falseis respected.["web"].postSearchWithFallbacktakes the fallback sources as an optional fourth argument, so existing callers keep working.src/service/search-surface.ts.Billing is unchanged: the API counts only web, news, image and index results toward search credits, and provider discovery is free. A live check returned the same
creditsUsedfor["web"]with and without Alexandria.Copy
Search descriptions, the
sourcesparameter and the server instructions replace thesources: ["web"]opt-out sentence with the always-on behaviour. The scrape description no longer says "withsourcesunset". The description stays within the 2,048-character cap.Tests
Summary by cubic
Authenticated
firecrawl_searchnow always asks for Alexandria provider matches, even when the caller passes sources that leave it out.sourcesarrays without Alexandria get it appended, preserving string or object form; omitted or emptysourcesstill default to["web", "alexandria"].["alexandria"]alone, keyless or credential-less sessions, andenterprise: ["zdr"]or["anon"]searches are unchanged.["web"];postSearchWithFallbacktakes the fallback sources as an optional fourth argument.creditsUsedmatches a["web"]-only request.Written for commit 5c40110. Summary will update on new commits.