Repository navigation
feat(keyless): forward a World ID credential on keyless requests - #559
Open
erikengervall wants to merge 2 commits into
Open
erikengervall wants to merge 2 commits into
erikengervall wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adds keyless-only World ID credential forwarding (header or FIRECRAWL_WORLD_ID option) with tests and a version bump; needs human sign-off on the quota/attribution and trust-model effects and on the unverified API-side gating claim.
View guided diff | Turn on auto-fix | Re-trigger cubic
erikengervall
force-pushed
the
capy/forward-a-world-id
branch
10 times, most recently
from
October 19, 2026 10:34
5defd65 to
2e0780c
Compare
erikengervall
force-pushed
the
capy/forward-a-world-id
branch
from
October 19, 2026 17:13
2e0780c to
b46bf29
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keyless requests can carry a World ID credential (
fcwid_...) asx-firecrawl-world-id, which firecrawl/firecrawl#4934 uses to count the request against the verified human's own keyless bucket instead of the IP.FIRECRAWL_WORLD_IDsets it (newworldIdCredentialserver option).authenticatewrapper copies anx-firecrawl-world-idrequest header onto the session (SessionData.worldIdCredential), the same way it records the client User-Agent, so embedders that admit keyless sessions forward it. A session value wins over the option.keylessPostsends it. Requests with an API key or OAuth token never do.Tests
tests/server-hooks.test.mjs: a keyless session sends the header from the request, else the option; a keyed session sends neither.node --test tests/*.test.mjs(172 passed) andpnpm run lint.Summary by cubic
Forwards a World ID credential (
fcwid_...) asx-firecrawl-world-idon keyless requests so the API can count them against the verified human's own keyless bucket instead of the IP.FIRECRAWL_WORLD_IDinto the newworldIdCredentialoption; HTTP servers copy thex-firecrawl-world-idrequest header onto the session, and a session value wins over the option.Written for commit b46bf29. Summary will update on new commits.