Repository navigation
End the search and scrape descriptions with the relay sentence - #562
Draft
rakshith48 wants to merge 8 commits into
Draft
rakshith48 wants to merge 8 commits into
rakshith48 wants to merge 8 commits into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # gemini-extension.json
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # server.json
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some MCP clients don't pass server instructions to the model, so the model only sees the tool descriptions. This PR ends the
firecrawl_searchandfirecrawl_scrapedescriptions with a relay sentence, so an agent on those clients also passes on the line that a credits, rate-limit or daily-limit error ends with.Changes
firecrawl_searchandfirecrawl_scrapedescriptions now end with this paragraph:The sentence goes last so each description still opens with what the tool does (the description budget test requires scrape to open with "Scrape one URL").
Alignment with fix: relay the upgrade line when Firecrawl usage runs out聽#547: this follows the wording of fix: relay the upgrade line when Firecrawl usage runs out聽#547's instructions sentence, which names credits and the daily limit without an account but not rate limits. Changing fix: relay the upgrade line when Firecrawl usage runs out聽#547's sentence to the one above would make the two identical.
Budget:
firecrawl_searchwas 2,039 characters, which left no room under the 2,048-character cap that Claude Code applies to tool descriptions. These cuts make room:categories,toolDetailandscrapeOptionsare described on their parameters." The parameter descriptions already cover this.data.tools.Search is now 2,037 characters and scrape is 1,387.
Release 3.33.3, with a changelog entry.
Tests
tests/mcp-description-budget.test.mjsasserts that both descriptions end with the sentence, and still checks that every description fits the 2,048-character cap with the routing copy inside it.pnpm run lint: clean.pnpm test: 188/188 pass.