Skip to content

chore: add type annotations and suppress known Ruff warnings - #1560

Merged
jstucke merged 1 commit into
replace-node-npm-with-bunfrom
fix_ruff_for_frontend
Oct 26, 2026
Merged

jstucke merged 1 commit into
replace-node-npm-with-bunfrom
fix_ruff_for_frontend

Conversation

@da-lauer

Copy link
Copy Markdown
Collaborator

Add missing type annotations and suppress Ruff warnings for intentional shell=True usage.

@da-lauer
da-lauer changed the base branch from master to replace-node-npm-with-bun October 25, 2026 21:52
@da-lauer
da-lauer requested a review from jstucke October 25, 2026 21:53
@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.50%. Comparing base (4fcdaee) to head (9c17889).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           replace-node-npm-with-bun    #1560      +/-   ##
=============================================================
- Coverage                      93.08%   92.50%   -0.58%     
=============================================================
  Files                            375      369       -6     
  Lines                          23568    21256    -2312     
=============================================================
- Hits                           21938    19663    -2275     
+ Misses                          1630     1593      -37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke jstucke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstucke
jstucke merged commit 695dccb into replace-node-npm-with-bun Oct 26, 2026
8 of 9 checks passed
@jstucke
jstucke deleted the fix_ruff_for_frontend branch October 26, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants