Skip to content

feet: Replace node npm with bun - #1565

Open
da-lauer wants to merge 5 commits into
masterfrom
replace-node-npm-with-bun
Open

da-lauer wants to merge 5 commits into
masterfrom
replace-node-npm-with-bun

Conversation

@da-lauer

Copy link
Copy Markdown
Collaborator

Change nodejs and npm to bun to make frontend-dependencies-installation faster

@da-lauer
da-lauer force-pushed the replace-node-npm-with-bun branch from 521652e to 57eaeed Compare November 12, 2026 12:17
@codecov-commenter

codecov-commenter commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (fa6a600) to head (57eaeed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
- Coverage   93.13%   92.53%   -0.60%     
==========================================
  Files         377      370       -7     
  Lines       23829    21312    -2517     
==========================================
- Hits        22193    19722    -2471     
+ Misses       1636     1590      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

<ul>
<li>Removed search redirect in case of one result</li>
<li>Install nodejs dependencies in nodeenv</li>
<li>Install frontend dependencies via bun</li>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a log of the changes in FACT 4.3 and does not need to be changed in this PR 😅
you could add a new line to 4.5-dev, though

Comment on lines +86 to +90
# install bun
if ! command -v bun &> /dev/null && [ ! -x "$HOME/.bun/bin/bun" ]; then
curl -fsSL https://bun.sh/install | bash
fi
export PATH="$HOME/.bun/bin:$PATH"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is installed via install/frontend.py, this should probably be removed

Comment thread src/install/frontend.py
PIP_DEPENDENCIES = INSTALL_DIR / 'requirements_frontend.txt'
STATIC_WEB_DIR = INSTALL_DIR.parent / 'web_interface' / 'static'
BUN_VERSION_FILE = INSTALL_DIR / 'bun-version.txt'
BUN_INSTALL_DIR = INSTALL_DIR / '.tools' / 'bun'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the bin dir (src/bin) already, so it would make more sense to reuse that one. That would mean a weird path though (bin/bun/bin/bun). We could also directly download the release from github and unpack just the binary directly to the bin dir. Then we could also add a hash check

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants