Repository navigation
Conversation
521652e to
57eaeed
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
- Coverage 93.13% 92.53% -0.60%
==========================================
Files 377 370 -7
Lines 23829 21312 -2517
==========================================
- Hits 22193 19722 -2471
+ Misses 1636 1590 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| <ul> | ||
| <li>Removed search redirect in case of one result</li> | ||
| <li>Install nodejs dependencies in nodeenv</li> | ||
| <li>Install frontend dependencies via bun</li> |
There was a problem hiding this comment.
That is a log of the changes in FACT 4.3 and does not need to be changed in this PR 😅
you could add a new line to 4.5-dev, though
| # install bun | ||
| if ! command -v bun &> /dev/null && [ ! -x "$HOME/.bun/bin/bun" ]; then | ||
| curl -fsSL https://bun.sh/install | bash | ||
| fi | ||
| export PATH="$HOME/.bun/bin:$PATH" |
There was a problem hiding this comment.
since it is installed via install/frontend.py, this should probably be removed
| PIP_DEPENDENCIES = INSTALL_DIR / 'requirements_frontend.txt' | ||
| STATIC_WEB_DIR = INSTALL_DIR.parent / 'web_interface' / 'static' | ||
| BUN_VERSION_FILE = INSTALL_DIR / 'bun-version.txt' | ||
| BUN_INSTALL_DIR = INSTALL_DIR / '.tools' / 'bun' |
There was a problem hiding this comment.
we have the bin dir (src/bin) already, so it would make more sense to reuse that one. That would mean a weird path though (bin/bun/bin/bun). We could also directly download the release from github and unpack just the binary directly to the bin dir. Then we could also add a hash check
Change nodejs and npm to bun to make frontend-dependencies-installation faster