Skip to content

Fix/hasura db config - #1568

Open
jstucke wants to merge 2 commits into
masterfrom
fix/hasura-db-config
Open

jstucke wants to merge 2 commits into
masterfrom
fix/hasura-db-config

Conversation

@jstucke

@jstucke jstucke commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator
  • This fixes a bug with Hasura: Hasura got the DB connection only from its containers' environment, which was set once at install time. Changing [common.postgres] later never reached it, so GraphQL kept querying the old DB while the rest of FACT used the new one.
  • some ruff fixes

jstucke and others added 2 commits November 18, 2026 11:12
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hasura got the DB connection only from the environment of its containers,
which was set when they were created during installation. A later change of
`[common.postgres]` never reached it, so GraphQL queried the old database
while the rest of FACT used the new one.

- the frontend now runs `docker compose up` for existing Hasura containers at
  start, which recreates them only if their environment changed
- the DB URL uses the configured database instead of a hard-coded `fact_db`
- the test setup of Hasura uses the configured server and test database
  instead of a hard-coded `fact_test` on the local socket

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jstucke jstucke self-assigned this Nov 18, 2026
@jstucke jstucke added the bug label Nov 18, 2026
@codecov-commenter

codecov-commenter commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.02970% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.54%. Comparing base (fa6a600) to head (25b33fd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/start_fact_frontend.py 75.00% 2 Missing ⚠️
src/storage/graphql/hasura/init_hasura.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
- Coverage   93.13%   92.54%   -0.60%     
==========================================
  Files         377      372       -5     
  Lines       23829    21393    -2436     
==========================================
- Hits        22193    19798    -2395     
+ Misses       1636     1595      -41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants