Skip to content

fix: misalignment caused by wrong placement of badges#4582

Merged
imorland merged 4 commits into
flarum:2.xfrom
blomstra:dk/user-badges-misalign
Jun 1, 2026
Merged

fix: misalignment caused by wrong placement of badges#4582
imorland merged 4 commits into
flarum:2.xfrom
blomstra:dk/user-badges-misalign

Conversation

@luceos
Copy link
Copy Markdown
Contributor

@luceos luceos commented Apr 17, 2026

Bug happens when replying,where the badges shift to the left of the avatar. This is caused by a wrong implementation in the component as they are positioned elsewhere based on username, not avatar element.

This is similar to the actual post implementation. The badges are weirdly aligned from the author username, not the avatar.

@luceos luceos requested a review from a team as a code owner April 17, 2026 17:44
Copy link
Copy Markdown
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @luceos

Unfortunately this change breaks the mobile view:

Image

This will need an accompanying styling change as well....

@imorland
Copy link
Copy Markdown
Member

@luceos will you have time to address this ahead of rc.2 in the coming days?

@luceos
Copy link
Copy Markdown
Contributor Author

luceos commented May 31, 2026

It's done @imorland.

Only now saw the addition pr by @huoxin233, should've checked sooner 🙈

@luceos luceos requested a review from imorland May 31, 2026 08:57
@huoxin233
Copy link
Copy Markdown
Contributor

huoxin233 commented May 31, 2026

It's done @imorland.

Only now saw the addition pr by @huoxin233, should've checked sooner 🙈

image

Your one didnt cover the part for duplicate avatar when editing, so probably I will do a merge also 🫣

https://github.com/flarum/framework/pull/4610/changes#diff-589e03833214a5b7c4920f93deceb20a05fdf719f55e8eb3948ed8e03979f912R409


Also do yall think its fine that the text is actually not align? (when doing new post or editing)
image

@imorland imorland merged commit b36ff09 into flarum:2.x Jun 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants