Prepare for new properties on int#9829
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request temporarily skips a debugger evaluation test for integers due to pending Dart SDK updates. The reviewer suggested adding a TODO with a tracking issue link to the skipped test to ensure it is re-enabled later, consistent with the project's maintainability guidelines.
kenzieschmoll
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a failure seen on the HHH bot, caused by new int members in the Dart SDK. I think this change has not yet made it to Flutter, as the devtools tests, as customer tests, haven't been flagged yet. The failure: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8681902379780991265/+/u/Run_customer_testing_tests/stdout?format=raw
Rather than dance around a sync forward or disabling the devtools tests wholesale as customer tests, in this change I just disable the one test. After the Dart roll into Flutter, we can bump our flutter candidate SHA and enable the test and correct it.