Merge marketing site into sites/www#13373
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Visit the preview URL for this PR (updated for commit 531a113): https://flutter-docs-prod--pr13373-feat-merge-website-cms-fq38782n.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
I know it's in draft, but lgtm
Co-authored-by: Abdallah Shaban <abdallahshaban@google.com> Co-authored-by: Alvaro Andrés Rodríguez Scelza <alvaroscelza@gmail.com> Co-authored-by: Brian Tobin <brianjtobin@gmail.com> Co-authored-by: Connie Ooi <connieooi@google.com> Co-authored-by: Craig Labenz <craig.labenz@gmail.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Emma Twersky <pokepsi@gmail.com> Co-authored-by: Eric Windmill <ewindmill@google.com> Co-authored-by: Jhon Aires <82902331+Jhon-Aires@users.noreply.github.com> Co-authored-by: John Ryan <ryjohn@google.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Khanh Nguyen <khanhnwin@gmail.com> Co-authored-by: Kilian Schulte <git@schultek.dev> Co-authored-by: Martin D'Uva <martin.duva@verygood.ventures> Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Pierre <6655696+guidezpl@users.noreply.github.com> Co-authored-by: Tom Arra <tarra3@gmail.com> Co-authored-by: Victoria Duran <37369214+vickyduran@users.noreply.github.com> Co-authored-by: btobin <brianjtobin@gmail.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: htrolle-epam <htrolle@google.com>
7c6f98e to
9b4960f
Compare
|
Staged preview of the updated docs.flutter.dev site (updated for commit 152adca): https://flutter-docs-prod--docs-pr13373-feat-merge-website-cms-ag6mn5jc.web.app |
flutter/website-cms repository into sites/wwwflutter/website-cms repository into sites/www
flutter/website-cms repository into sites/wwwsites/www
|
@abdallahshaban557 can you look over? |
Focused changes after merge: https://github.com/flutter/website/pull/13373/changes/9b4960f53296de3f5393b0b437c339e34703adad..152adca768e3b8eba67e9e2afec7a6aa15815bd8
This PR merges the old
flutter/website-cmsmarketing site into this repository as thesites/wwwdirectory, resulting influtter.devliving alongsidedocs.flutter.devin the shared Dart pub workspace.It updates the shared
dash_sitetooling so both sites can be built, served, cleaned, checked, staged, and deployed with a shared and consistent setup. The Cloud Build staging/deploy flows have been been migrated from Bash scripts to Dart commands withindash_sitefor easier maintainence since their logic got more complicated. The GitHub Actions workflows are now split for docs site, marketing site, and Dart tests.TODO: Move trigger for marketing site from
flutter/website-cmsto this repository and set the_SITEcustom substitution towww.