Fix macOS/AMD render corruption and depth issues#2298
Open
vkedwardli wants to merge 1 commit into
Open
Conversation
…endering (fixes macOS/AMD render corruption and depth issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1172 Vulkan rendering corruption and depth-ordering issues seen on macOS/AMD, by adding a toggleable non-reversed depth path for both standard and OIT rendering.
The new
Non Reversed DepthVulkan option keeps the original reversed-Z path as the default, and enables the alternate path only when needed.On macOS/AMD with Vulkan, the default reversed-Z path could produce incorrect rendering in both regular and OIT scenes, including:
The OIT version also avoids fragment discard during insertion, which was causing missing alpha/UI/shadow on macOS/AMD
The goal of this PR is to verify that the macOS/AMD Vulkan issue can be fixed and to preserve a working reference for that fix.