feat(speakers): display unique activities count on speakers/submitters list#933
Open
mulldug wants to merge 2 commits into
Open
feat(speakers): display unique activities count on speakers/submitters list#933mulldug wants to merge 2 commits into
mulldug wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR adds activities count tracking to speaker and submitter selection flows. Redux actions fetch event counts from API endpoints, reducers store the counts in state, internationalization provides conditional messaging based on whether the count is accurate, and the speaker list page displays the counts in its header and selection labels. ChangesActivities Count Tracking for Speakers and Submitters
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webpack.dev.js`:
- Line 11: The dev server was changed to use HTTP via the server: { type: "http"
} setting in webpack.dev.js which can break HTTPS-only features and OAuth
redirect URIs; either revert to HTTPS by configuring the dev server to use TLS
(provide cert/key or use a local CA tool like mkcert) or, if you must keep HTTP,
add a checklist and guards to verify authentication/OAuth redirect URIs, secure
cookies, service worker registration, and secure-context dependent APIs work in
development; update the webpack.dev.js server configuration (the server object)
and any development docs to reflect the chosen approach so dev/prod parity is
preserved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 715e5fb9-188e-445d-a67f-c7350fa98eef
📒 Files selected for processing (8)
src/actions/speaker-actions.jssrc/actions/submitter-actions.jssrc/i18n/en.jsonsrc/pages/summit_speakers/summit-speakers-list-page.jssrc/reducers/summit_speakers/summit-speakers-list-reducer.jssrc/reducers/summit_submitters/summit-submitters-list-reducer.jssrc/reducers/summits/current-summit-reducer.jswebpack.dev.js
| devServer: { | ||
| historyApiFallback: true, | ||
| server: { type: "https" } | ||
| server: { type: "http" } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check for HTTPS-dependent features that may break with HTTP dev server
echo "=== Checking for Service Workers ==="
rg -n --type=js --type=ts -C2 'navigator\.serviceWorker|registerServiceWorker'
echo -e "\n=== Checking for Secure Cookie usage ==="
rg -n --type=js --type=ts -C2 'secure:\s*true|; secure'
echo -e "\n=== Checking for HTTPS-only Web APIs ==="
rg -n --type=js --type=ts -C2 'navigator\.geolocation|Notification\.requestPermission|navigator\.mediaDevices'
echo -e "\n=== Checking for OAuth/Auth configuration ==="
rg -n --type=js --type=ts -C2 'oauth|OAuth|redirect.*[Uu]ri'Repository: fntechgit/summit-admin
Length of output: 6670
Verify HTTP development server compatibility with your application's security features.
Switching from HTTPS to HTTP in development creates a dev/prod parity gap if your production environment uses HTTPS. Before deployment, confirm that:
- Authentication and OAuth flows work correctly with HTTP redirect URIs
- No security-sensitive features (like service workers or secure cookies) are inadvertently broken
- Browser compatibility is maintained for any features relying on secure contexts
If this change was made to work around local development issues, consider alternatives like mkcert for self-signed certificates to preserve HTTPS in development.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@webpack.dev.js` at line 11, The dev server was changed to use HTTP via the
server: { type: "http" } setting in webpack.dev.js which can break HTTPS-only
features and OAuth redirect URIs; either revert to HTTPS by configuring the dev
server to use TLS (provide cert/key or use a local CA tool like mkcert) or, if
you must keep HTTP, add a checklist and guards to verify authentication/OAuth
redirect URIs, secure cookies, service worker registration, and secure-context
dependent APIs work in development; update the webpack.dev.js server
configuration (the server object) and any development docs to reflect the chosen
approach so dev/prod parity is preserved.
smarcet
reviewed
Jun 4, 2026
| devServer: { | ||
| historyApiFallback: true, | ||
| server: { type: "https" } | ||
| server: { type: "http" } |
There was a problem hiding this comment.
@mulldug we are all running on SSL locally please rollback this
|
@mulldug please rebase onto main and resolve the merge conflicts. Many thanks. |
smarcet
requested changes
Jun 4, 2026
…s list Add total filtered activities count to the page header alongside the speaker count, and selected activities count above the grid, for both the Speakers and Submitters views. Activity counts are deduplicated across accepted, alternate, and rejected presentations using a Set client-side for selections and a dedicated backend endpoint for the filtered total. Also fix null guards in current-summit-reducer for reg-lite and print-app settings payloads.
…iltered results Show "Selected N Speakers | M Activities" only when the full filtered set is selected (selectedAll with no exclusions), where totalActivities from the backend is accurate. Fall back to "Selected N Speakers" for partial or cross-page selections where a correct count cannot be determined client-side.
mulldug
force-pushed
the
feature/speakers-submitters-activities-count
branch
from
cb36a45 to
54b7461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b9b1qrk
Add total filtered activities count to the page header alongside the speaker count, and selected activities count above the grid, for both the Speakers and Submitters views. Activity counts are deduplicated across accepted, alternate, and rejected presentations using a Set client-side for selections and a dedicated backend endpoint for the filtered total.
Also fix null guards in current-summit-reducer for reg-lite and print-app settings payloads, and switch dev server to http.
Summary by CodeRabbit
New Features
Improvements