@W-21933885: [MSDK Android] App Attestation Implementation (Increase Test Code Coverage For NativeLoginManager.createRequestBody)

Author: JohnsonEricAtSalesforce

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/NativeLoginManager.kt

@@ -145,6 +145,7 @@ internal class NativeLoginManager(
             CONTENT_TYPE_HEADER_NAME to CONTENT_TYPE_VALUE_HTTP_POST,
             AUTHORIZATION to "$AUTH_AUTHORIZATION_VALUE_BASIC $encodedCreds",
         )
+        // TODO: Needs Coverage. ECJ20260416
         val attestationValue = getInstance().appAttestationClient?.createSalesforceOAuthAuthorizationAppAttestation()
         val authRequestBody = createRequestBody(
             ATTESTATION to attestationValue,
@@ -242,9 +243,10 @@ internal class NativeLoginManager(
         }
     }
 
-    private fun createRequestBody(vararg kvPairs: Pair<String, String?>): RequestBody {
-        kvPairs.filter { it.second != null }
-        val requestBodyString = kvPairs.joinToString("&") { (key, value) -> "$key=$value" }
+    @VisibleForTesting
+    internal fun createRequestBody(vararg kvPairs: Pair<String, String?>): RequestBody {
+        // TODO: Needs Coverage. ECJ20260416
+        val requestBodyString = kvPairs.filter { it.second != null }.joinToString("&") { (key, value) -> "$key=$value" }
         val mediaType = CONTENT_TYPE_VALUE_HTTP_POST.toMediaTypeOrNull()
         return requestBodyString.toRequestBody(mediaType)
     }

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/NativeLoginManagerTest.kt

@@ -8,12 +8,11 @@ import com.salesforce.androidsdk.app.SalesforceSDKManager
 import com.salesforce.androidsdk.security.BiometricAuthenticationManager
 import org.junit.After
 import org.junit.Assert
+import org.junit.Assert.assertEquals
 import org.junit.Before
-import org.junit.Ignore
 import org.junit.Test
 import org.junit.runner.RunWith
 
-@Ignore
 @RunWith(AndroidJUnit4::class)
 @SmallTest
 class NativeLoginManagerTest {
@@ -90,8 +89,17 @@ class NativeLoginManagerTest {
         Assert.assertEquals("Should return username.", "test_username", mgr.biometricAuthenticationUsername)
     }
 
+    @Test
+    fun nativeLoginManager_createRequestBody_filtersNullValues() {
+
+        val result = mgr.createRequestBody("key1" to "value1", "key2" to null)
+
+        val buffer = okio.Buffer()
+        result.writeTo(buffer)
+        assertEquals("key1=value1", buffer.readUtf8())
+    }
 
     private fun addUserAccount() {
-        UserAccountManager.getInstance().createAccount(UserAccountTest.createTestAccount());
+        UserAccountManager.getInstance().createAccount(UserAccountTest.createTestAccount())
     }
 }