Skip to content

fix(ci): use github.token for release workflows - #226

Merged
soimkim merged 1 commit into
mainfrom
fix/release-github-token
Oct 28, 2026
Merged

soimkim merged 1 commit into
mainfrom
fix/release-github-token

Conversation

@soimkim

@soimkim soimkim commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use the workflow github.token instead of secrets.TOKEN for changelog updates, the main-branch push, and release asset upload.
  • Apply the same change to Release Drafter, which called the GitHub API with the same rejected secret.
  • Release job logs showed Contents: write on github.token, which covers release reads, asset uploads, and the changelog push. secrets.TOKEN returned HTTP 401.

Test plan

  • Merge this change to main before re-running the release workflow, because release workflows load the workflow file from the default branch.
  • Re-run the v5.1.35 release workflow and confirm Upload Release Asset no longer returns Bad credentials.
  • Confirm gren can list releases and the changelog commit is pushed.
  • Open or update a pull request and confirm Release Drafter still updates the draft release.

The stored TOKEN secret is rejected by the GitHub API, so release asset upload and changelog updates fail.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim soimkim self-assigned this Oct 28, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Oct 28, 2026
@soimkim
soimkim merged commit e7c56e1 into main Oct 28, 2026
4 of 7 checks passed
@soimkim
soimkim deleted the fix/release-github-token branch October 28, 2026 03:57
soimkim added a commit that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant