add regex whitelist to no-arbitrary-values#398
Open
ginasummation wants to merge 2 commits intofrancoismassart:masterfrom
Open
add regex whitelist to no-arbitrary-values#398ginasummation wants to merge 2 commits intofrancoismassart:masterfrom
ginasummation wants to merge 2 commits intofrancoismassart:masterfrom
Conversation
|
👍 to this please! |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Name
Add a whitelist for no-arbitrary-values rule
Description
I'm using the no-arbitrary-values rule to enforce team consistency with a design system. Our design system is not opinionated on a subset of tailwind classes though (mostly height and width related) so I would like to whitelist those sort of classes to allow for arbitrary values. See similar asks from these two issues
#286
#247
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I added a unit test with various whitelist options to make sure the change works. I also made sure the regex would allow users to specify the content within the arbitrary values. I,e whitelisting 'text-[12px]' but disallowing 'text-[#ffffff]'
Checklist: