Add rule type to meta to comply with expected custom rule shape#429
Open
brokentone wants to merge 1 commit intofrancoismassart:masterfrom
Open
Add rule type to meta to comply with expected custom rule shape#429brokentone wants to merge 1 commit intofrancoismassart:masterfrom
brokentone wants to merge 1 commit intofrancoismassart:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Name
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Eslint expects a certain structure, of which meta.type is expected: https://eslint.org/docs/latest/extend/custom-rules#rule-structure
This powers the ESLint cli (or node API) functionality to filter by a type of rule when fixing. https://eslint.org/docs/latest/use/command-line-interface#--fix-type When nothing is specified, the rule cannot be selected for at all.
I selected the type of "suggestion" for which the definition is:
I believe all the rules here, while possibly strong suggestions, are suggestions when read in this manner.
Type of change
How Has This Been Tested?
I ran the supplied tests and they still pass, as well as I made the corollary updates to a project that was showing violations of this rule which were not previous fixable, and now are fixable.
Test Configuration:
Checklist: