Repository navigation
Add energy formulas - #143
Open
Mohammad-Tayyab-Frequenz wants to merge 3 commits into
Open
Mohammad-Tayyab-Frequenz wants to merge 3 commits into
Mohammad-Tayyab-Frequenz wants to merge 3 commits into
Conversation
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Mohammad-Tayyab-Frequenz
requested review from
Marenz
and removed request for
a team
October 19, 2026 18:55
github-actions
Bot
added
part:tests
cwasicki
reviewed
Oct 21, 2026
| except ValueError: | ||
| pass | ||
| return {"AC_POWER_ACTIVE": derived} | ||
| return {metric: derived for metric in _AUTO_FORMULA_METRICS} |
Collaborator
There was a problem hiding this comment.
Can't we resolve energies to power here instead? Otherwise we will end up duplicating the same summation formula for every metric.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
AC_ENERGY_ACTIVE,AC_ENERGY_ACTIVE_CONSUMED, andAC_ENERGY_ACTIVE_DELIVEREDto_derive_component_configsfunction.