Repository navigation
Conversation
…s out A scroll position that is not driving the sheet (e.g. an offstage scrollable sharing the same SheetScrollController) delegated goBallistic and goIdle to the sheet whenever any other position was primary. When such a position relaid out during a drag, it replaced the sheet's active drag activity and the drag was lost. Only the primary scroll position delegates to the sheet now; other positions run their own ballistic and idle activities.
fujidaiti
enabled auto-merge (squash)
November 14, 2026 04:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sheet drag can be cancelled in the middle of the gesture when a second scroll position attached to the same SheetScrollController relays out. For example, a sheet that contains an Offstage scrollable and a visible scrollable sharing one SheetScrollController: while the user drags the sheet, the hidden scrollable's content size changes, the sheet stops following the finger and the drag is lost.
SheetScrollPosition.goIdle and goBallistic delegated to the sheet whenever any scroll position was primary, not only when the position itself was. A non-primary position that relaid out therefore called goBallistic(0) on the sheet, which replaced the sheet's active drag activity. Only the primary scroll position delegates to the sheet now; other positions run their own idle and ballistic activities.
A regression test reproduces the scenario with an offstage scrollable whose content grows in the middle of a drag.