Repository navigation
Conversation
SheetDraggable creates its VerticalDragGestureRecognizer by hand and never applied the inherited MediaQuery gesture settings, so a custom touch slop was ignored when a drag started on a non-scrollable part of the sheet, while Scrollable and GestureDetector honor it. The recognizer now follows MediaQuery.gestureSettings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MediaQuery provides custom gesture settings, for example a smaller touchSlop, a drag that starts on a non-scrollable part of a sheet still needs to travel the default 18 logical pixels before the sheet starts moving, while Scrollable and GestureDetector honor the custom value. This makes sheet drags feel inconsistent with the rest of the UI.
SheetDraggable builds its VerticalDragGestureRecognizer by hand and never applied the inherited gesture settings. The recognizer now follows MediaQuery.gestureSettings, and the default touch slop is unchanged when the MediaQuery provides none.