Repository navigation
fix(ui): group dropdown in the rule form does not open - #577
Merged
Merged
Conversation
daisyUI 5 sets pointer-events: none on a focused '.dropdown > [tabindex]:first-child'. The CustomSelect <summary> had tabindex=0, so on mousedown it got focus, lost pointer events, and the click landed on <details>, which never opened. <summary> is natively focusable: drop the tabindex. Regression from the daisyUI 5 upgrade.
📦 Extension Build Ready!Version: 📥 Download Extension (tabee.zip)Installation
Status
🤖 Auto-generated by GitHub Actions |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576.
Problem
In the Add / Edit rule modal, clicking the Group dropdown does nothing, so a rule can't be assigned to an existing group. Same for every
CustomSelect(theme in Settings, group color). Regression from the daisyUI 5 upgrade (#565), first shipped in 1.1.8.Cause
daisyUI 5's dropdown CSS has:
meant for focus-based dropdowns. Our
<summary>hadtabindex="0"and is the first child ofdetails.dropdown. On mousedown it gets focus → loses pointer events → the mouseup lands on<details>→ the click target is<details>, not<summary>, so it never toggles.Confirmed in Chromium with the built extension: the click reached the page with
target=DETAILSand notoggleevent; after mousedown, the element under the pointer wasdetails, notsummary.Fix
Remove
tabindex="0"from the<summary>: it is natively focusable and keyboard-operable.Tests
<summary>inCustomSelect.vuehas notabindex(jsdom doesn't apply CSS, so a real click test isn't possible there). Fails onmaster.vue-tscand build pass.