Skip to content

fix(ui): group dropdown in the rule form does not open - #577

Merged
sebastienfontaine merged 1 commit into
masterfrom
fix/group-dropdown-not-opening
Oct 26, 2026
Merged

sebastienfontaine merged 1 commit into
masterfrom
fix/group-dropdown-not-opening

Conversation

@sebastienfontaine

Copy link
Copy Markdown
Contributor

Fixes #576.

Problem

In the Add / Edit rule modal, clicking the Group dropdown does nothing, so a rule can't be assigned to an existing group. Same for every CustomSelect (theme in Settings, group color). Regression from the daisyUI 5 upgrade (#565), first shipped in 1.1.8.

Cause

daisyUI 5's dropdown CSS has:

.dropdown:focus-within > [tabindex]:first-child { pointer-events: none }

meant for focus-based dropdowns. Our <summary> had tabindex="0" and is the first child of details.dropdown. On mousedown it gets focus → loses pointer events → the mouseup lands on <details> → the click target is <details>, not <summary>, so it never toggles.

Confirmed in Chromium with the built extension: the click reached the page with target=DETAILS and no toggle event; after mousedown, the element under the pointer was details, not summary.

Fix

Remove tabindex="0" from the <summary>: it is natively focusable and keyboard-operable.

Tests

  • Regression test: the <summary> in CustomSelect.vue has no tabindex (jsdom doesn't apply CSS, so a real click test isn't possible there). Fails on master.
  • Real browser (Playwright, built extension), editing a sample rule: dropdown opens on click, lists the 3 groups, closes after choosing, shows the choice, rule saved with the new group, and opens with the keyboard (Enter).
  • 259 tests, ESLint, Prettier, vue-tsc and build pass.

daisyUI 5 sets pointer-events: none on a focused
'.dropdown > [tabindex]:first-child'. The CustomSelect <summary> had
tabindex=0, so on mousedown it got focus, lost pointer events, and the
click landed on <details>, which never opened. <summary> is natively
focusable: drop the tabindex. Regression from the daisyUI 5 upgrade.
@github-actions

Copy link
Copy Markdown

📦 Extension Build Ready!

Version: 1.1.8

📥 Download Extension (tabee.zip)

Installation

  1. Download and extract the zip file
  2. Open Chrome → chrome://extensions/
  3. Enable "Developer mode" (top right)
  4. Click "Load unpacked" → Select the extracted folder

Status

  • ✅ All tests passed
  • ✅ Build successful
  • ✅ Ready for testing

🤖 Auto-generated by GitHub Actions

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 59.24% 692 / 1168
🔵 Statements 59.55% 729 / 1224
🔵 Functions 66.35% 142 / 214
🔵 Branches 54.75% 351 / 641
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/global/CustomSelect.vue 100% 100% 100% 100%
Generated in workflow #483 for commit 5253f37 by the Vitest Coverage Report Action

@sebastienfontaine sebastienfontaine self-assigned this Oct 26, 2026
@sebastienfontaine
sebastienfontaine merged commit 7663e3d into master Oct 26, 2026
7 checks passed
@sebastienfontaine
sebastienfontaine deleted the fix/group-dropdown-not-opening branch October 26, 2026 13:50
@sebastienfontaine sebastienfontaine mentioned this pull request Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group dropdown in Add/Edit rule modal does not open – existing groups never shown (Edge 155)

1 participant