fix: add explicit timeout to async aiohttp requests#179
Open
dpmworld wants to merge 1 commit into
Open
Conversation
The async request path created a new `aiohttp.ClientSession()` without specifying a timeout, which falls back to aiohttp's default of 5 minutes. The synchronous `requests` path uses a 30 second timeout, so a hung connection produced very different failure modes between the two code paths. Pass an explicit `ClientTimeout(total=30)` to the session to align the async path with the sync path and to fail fast when the upstream service is unresponsive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async request path created a new
aiohttp.ClientSession()without specifying a timeout, which falls back to aiohttp's default of 5 minutes. The synchronousrequestspath uses a 30 second timeout, so a hung connection produced very different failure modes between the two code paths.Pass an explicit
ClientTimeout(total=30)to the session to align the async path with the sync path and to fail fast when the upstream service is unresponsive.