Skip to content

fix: keep Nuos operation mode cache in sync with mode getter #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpmworld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: keep Nuos operation mode cache in sync with mode getter #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ariston/nuos_split_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,14 @@ async def async_set_water_heater_reduced_temperature(self, temperature: float):
def set_water_heater_operation_mode(self, operation_mode: str):
"""Set water heater operation mode"""
self.api.set_nuos_mode(self.gw, NuosSplitOperativeMode[operation_mode])
self.data[NuosSplitProperties.MODE] = NuosSplitOperativeMode[
# The Nuos cloud payload exposes two distinct fields: `mode` (the
# plant mode shared with other Velis devices) and `opMode` (the
# operative mode specific to Nuos: GREEN / COMFORT / FAST / IMEMORY).
# `set_nuos_mode` posts to `/operativeMode`, so the server updates
# `opMode`. The `water_heater_mode_value` getter also reads `opMode`,
# so the optimistic cache update has to mirror that field, not the
# generic `mode`.
self.data[NuosSplitProperties.OP_MODE] = NuosSplitOperativeMode[
operation_mode
].value

Expand All @@ -184,7 +191,10 @@ async def async_set_water_heater_operation_mode(self, operation_mode: str):
await self.api.async_set_nuos_mode(
self.gw, NuosSplitOperativeMode[operation_mode]
)
self.data[NuosSplitProperties.MODE] = NuosSplitOperativeMode[
# See note in `set_water_heater_operation_mode`: the cloud
# /operativeMode endpoint updates `opMode`, which is also what the
# `water_heater_mode_value` getter reads.
self.data[NuosSplitProperties.OP_MODE] = NuosSplitOperativeMode[
operation_mode
].value

Expand Down