change tls to use lax tls version and legacy ciphers#2
Open
JonathanPrince wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having connection issues with the TLS handshake being rejected by version/cipher mismatches.
connect_to_serverbuilds the context withssl._create_unverified_context(), disabling cert verification but it will inherit OpenSSL 3.x defaults: TLS 1.2 minimum + SECLEVEL=2.SECLEVEL 2 disables SHA-1 ciphers, RSA key exchange, and 3DES
Allowing the downgrade shouldn't be an issue but will allow connections to mainframes with old TLS and sad old ciphers. Happy to gate this behind a
--lax-tlsflag if you'd rather keep the strict context as the default, just let me know and I'll add the toggle.