Refactor out a function to tell whether a package is both MSYS/MINGW or not

This function will be used to determine whether a release note is added
without _both_ the MSYS and MINGW packages having been deployed.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/component-updates.js

@@ -42,6 +42,10 @@ const isMSYSPackage = package_name => {
         && !package_name.startsWith('mingw-w64-')
 }
 
+const packageNeedsBothMSYSAndMINGW = package_name => {
+    return ['openssl', 'curl', 'gnutls', 'pcre2'].includes(package_name)
+}
+
 const needsSeparateARM64Build = package_name => {
     if (package_name === 'git-extra') return true
     return package_name.startsWith('mingw-w64-') && ![
@@ -108,5 +112,6 @@ module.exports = {
     guessReleaseNotes,
     prettyPackageName,
     isMSYSPackage,
+    packageNeedsBothMSYSAndMINGW,
     needsSeparateARM64Build
 }

GitForWindowsHelper/slash-commands.js

@@ -54,7 +54,7 @@ module.exports = async (context, req) => {
 
             await checkPermissions()
 
-            const { guessComponentUpdateDetails } = require('./component-updates')
+            const { guessComponentUpdateDetails, packageNeedsBothMSYSAndMINGW } = require('./component-updates')
             const { package_name, version } = guessComponentUpdateDetails(req.body.issue.title, req.body.issue.body)
 
             await thumbsUp()
@@ -96,7 +96,7 @@ module.exports = async (context, req) => {
                 );
                 ({ html_url: commentURL, id: commentId } = await appendToIssueComment(context, await getToken(), owner, repo, commentId, `The${packageType ? ` ${packageType}` : ''} workflow run [was started](${answer.html_url})`))
             }
-            if (!['openssl', 'curl', 'gnutls', 'pcre2'].includes(package_name)) {
+            if (!packageNeedsBothMSYSAndMINGW(package_name)) {
                 await openPR(package_name)
             } else {
                 await openPR(package_name, 'MSYS')